Re: [xml] addSibling missing check for element equality

On Wed, Mar 11, 2009 at 12:48:54PM +0100, Kris Breuker wrote:

The functions xmlAddNextSibling and xmlAddPrevSibling have a check which  
checks if the element to be added is the same as the reference element.  
xmlAddSibling however does not have such a check, resulting in the loss  
of the element (the call to xmlUnlinkNode(elem) will unlink cur). I  
think the equality check should be added to addSibling as well, like in  
the attached patch.

  yes that makes perfect sense !
Applied and commited,

   thanks a lot !


Daniel Veillard      | libxml Gnome XML XSLT toolkit
daniel veillard com  | Rpmfind RPM search engine | virtualization library

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]