Re: [xml] Adding a build/configure *option* to use ICU converters

Hi Mark,

Glad that you liked my patch.

2007/9/27, Mark Rowe <mrowe apple com>:

On 26/09/2007, at 09:48, Jungshik Shin wrote:

Some non-Gnome projects on non-Linux platforms use libxml2, but they
also relyon ICU for character encoding conversion in the rest of the
project. They end
up having two sets of character encoding converters,  iconv and ICU
converters, which can increase the download size significantly.

For those projects, it'd be very nice to have a configuration option
in libxml2 that allow them
to use ICU converters rather than libiconv.

I made a preliminary patch and uploaded it to bugzilla ( ).
It works well on Windows, but I haven't yet managed to change so that it has an 'with-icu' option.

Nice work!  I've only skimmed over your patch, but it looks very
similar to patch in Apple's version of libxml2 that I did a few months
ago to have it optionally use ICU rather than iconv.  Our motivating
reasons were also similar: the download size and memory footprint that
having two libraries for character set conversion introduced.  Sadly I
did not find the time to make our patch available so far, or it could
have saved some duplication of effort here.

Indeed. It'd have been nice and have saved duplicated efforts if I had
known your patch. :-)
(actually, I also made my patch ~3 months ago, but was lazy ..... :-) )

I wonder what others think about this.  It'd be also nice if somebody
could help me with patching and related files to add
'-with-icu' option.

My patch includes the changes to allow this.  I'll send you a copy
shortly that you can take the relevant snippet from.

Thanks a lot for your help. I'm looking forward to your patch.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]