Re: [xml] minor compile warnings

Daniel Veillard wrote:
On Thu, Nov 22, 2007 at 11:29:49PM +0100, Hannes Eder wrote:
the attached patch fixes the warnings below in libxml2-2.6.28:

  In general it's best to report with the latest versions 2.6.30 ATM

compiler: gcc (GCC) 3.4.4 (cygming special, gdc 0.12, using dmd 0.125)
and yes ... it's cygwin ;)

encoding.c:1706: warning: passing arg 2 of `libiconv' from
incompatible pointer type

  Diverging definitions for iconv() . man iconv on Linux states:

size_t iconv(iconv_t cd,
             char **inbuf, size_t *inbytesleft,
             char **outbuf, size_t *outbytesleft);

 so that patch can't be applied, sorry

If you use AM_ICONV in you will see a check for iconv declaration and you should take care if ICONV_CONST is defined ! FYI Second argument of function is const when iconv is build as separate library.

So that please update as add AM_ICONV macro and update source to use ICONV_CONST at right places.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]