Re: [xml] patch for indenting comments/PIs in xmlsave
- From: Daniel Veillard <veillard redhat com>
- To: Jason Viers <lists beanalby net>
- Cc: xml gnome org
- Subject: Re: [xml] patch for indenting comments/PIs in xmlsave
- Date: Tue, 13 Mar 2007 14:12:22 -0400
On Tue, Mar 13, 2007 at 01:36:57PM -0400, Jason Viers wrote:
Daniel Veillard wrote:
changing the comments textual content is of course not acceptable. So the
improvement is far from systematic, in some case it is worse IMHO
Agreed that there's no good way to indent multi-line comments and they
should be left alone.
What about having it only indent single-line comments/PIs?
that's a bit strange IMHO
xmlNodeListDumpOutput could look through the contents and indent if
I though about this indentation problem a long time ago, an at the time
decided to not bother, it actually took quite some time before someone
reopened the question :-)
I'm undecided, the status quo isn't really broken since 'indenting'
cannot be perfect by definition, on the other hand this can be considered
though it doesn't work well in all cases. I'm also a bit worried of
potential breakage this could introduce (it should not but ...)
What do others think ?
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard redhat com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
] [Thread Prev