Re: [xml] patch: support <embed> in HTML parser

On Wed, Apr 25, 2007 at 09:20:51PM +1000, Michael Day wrote:
Hi Daniel,

<grin/> where is the limit ?

So far <embed> is the only element I've seen that triggers error 
messages from the HTML parser. Then again, it doesn't seem to support 
<blink>, but I'm not sure if any site uses it unironically these days :)

  hum, okay ...

In practice what were the problems except getting (rightful) error 
messages ?

Confusing error messages. Since the HTML parser already supports 
<applet> and <iframe> it doesn't seem like there is any harm in adding 
<embed> as well.

  you mean it's bad so it's okay to make it worse ;-) ?
Actually I understand the logic, don't worry !

 is it an empty element ? I would tag it as deprecated though.
See _htmlElemDesc in HTMLparser.h

Actually no, it doesn't seem to be an empty element at all, and it 
should be deprecated, and also only in the loose DTD, so could switch 
the patch to look like this:

+{ "embed",   0, 1, 2, 0, 1, 1, 1, "generic embedded object ",
+     EMPTY, NULL, DECL embed_attrs, NULL, NULL

Is endTag=1 correct? (means the end tag can be omitted).

 other elements would close it then. I must admit I don't fully remember
the algorithm ...

There is also a 
value of 3, meaning "the tag is stylistic and should be closed easily", 
but I don't really know what that means.

 things like <b> or <em> which people or editors usually mess up. I don't
think it's in that class, but should still be autoclosed to some extend, yes.

  Send an updated patch :-), thanks !


Red Hat Virtualization group
Daniel Veillard      | virtualization library
veillard redhat com  | libxml GNOME XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]