Re: [xml] xmlIO enhancements?

[Daniel Veillard <veillard redhat com>]

On Tue, Apr 05, 2005 at 04:06:46PM -0400, Joel Reed wrote:
> On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote:
> > I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have
> > two quick questions/possible improvements (i'll fire off a patch if no
> > dissenters).
>
> i better stop looking at xmlIO.c! is it me or is
> xmlNoNetExists and xmlSysIDExists the exact same function with different
> names? excessive copying & pasting perhaps? probably just needs some #ifdef
> reworking, search & replace, and delete one of them.

  They certainly share a lot, yes :-)
The hardest part is when they should be compiled in, one is catalog related
the other one might be completely generic.

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/