Re: [xml] xmlIO enhancements?

On Tue, Apr 05, 2005 at 04:06:46PM -0400, Joel Reed wrote:
On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote:
I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have
two quick questions/possible improvements (i'll fire off a patch if no

i better stop looking at xmlIO.c! is it me or is
xmlNoNetExists and xmlSysIDExists the exact same function with different
names? excessive copying & pasting perhaps? probably just needs some #ifdef
reworking, search & replace, and delete one of them.

  They certainly share a lot, yes :-)
The hardest part is when they should be compiled in, one is catalog related
the other one might be completely generic.


Daniel Veillard      | Red Hat Desktop team
veillard redhat com  | libxml GNOME XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]