Re: [xml] Default Catalog On Windows, Deprecated API

[Daniel Veillard <veillard redhat com>]

On Wed, Jun 09, 2004 at 04:16:35PM +0200, Igor Zlatkovic wrote:
> Hi there,
>
> Since I am changing the distribution paths, I can as well set a 
> meaningful default location for catalogs.
>
> The attached patch to catalog.c modifies xmlInitializeCatalog function 
> to look for ../etc/catalog relative to the location of the libxml2 
> shared library. This path is discovered at runtime when the function is 
> first called. Of course, this is Windows only, others remain with the 
> hardcoded default path.
>
> If there are no objections to this, I'll commit.
>
> Daniel: The last two changes in the patch remove the code from the two 
> deprecated functions. I posted about this, the current implementation 
> can return an address of the local variable. Perhaps this should just be 
> reverted, as you said, but I find it better to call the new API instead. 
> Now, should I commit or revert?

  I applied the patch, but removed your 2 last changes, because using
the deprecated function would result in memory leaks in the application, so
I don't think it's a good idea...

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/