[xml] Re: [xslt] libxml2-2.6.11 -- 1. gcc warning, 2. elfgcchack Question



[Cc'ing the list]

On Thu, Jul 08, 2004 at 10:12:33AM +0200, Peter Breitenlohner wrote:
On Thu, 22 Apr 2004 I had sent you another mail, but since I never got a
response I suspect that either my mail or your answer got lost in the bulk
of unwanted messages. The essential part of that old mail was:

**************************************************

On Wed, 25 Feb 2004, Daniel Veillard wrote:

....... Please consider reading the spec while reviewing the code, you
can't really do the later without knowing the former.

meanwhile I have read the specs ...................... In doing so I
noticed that the existing libxml2 (<=2.6.9) does not obey section 6.2
(Public Identifier Normalization) of the specs:

-----------------------------------------
In order to accurately and interoperably compare public identifiers, catalog
   processors must perform normalization on public identifiers in both the
   catalog and the input passed to them.

   All strings of white space in public identifiers must be normalized to
   single space characters (#x20), and leading and trailing white space must
   be removed.
-----------------------------------------

This is certainly not done in the present version, at least not as
implemented in the xmlcatalog application. I have tried:

      xmlcatalog --shell
      > public "-//OASIS//DTD DocBook XML V4.1.2//EN"         => found
      > public " -//OASIS//DTD DocBook XML V4.1.2//EN"        => not found
      > public "-//OASIS//DTD DocBook XML V4.1.2//EN "        => not found
      > public "-//OASIS//DTD DocBook XML  V4.1.2//EN"        => not found

and with analogous results if the catalog entries are modified instead of
the input.

If the `must' in the specs is interpreted as manatory requirement, the only
reliable way to do that probably is in catalog.c, even if that may be
awkward if temporary strings have to be created that are later to be freed
(by whom and when?).

  Hum, right. Basically all public entry point using Public ID should be
patched to check this and if needed a new string should be allocated.
That would need a new function for this, and a few more line in all those 
functions ... Not very hard but admitedly boring :-)

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]