[xml] xmlRegisterOutputCallbacks() doesn't set xmlOutputCallbackInitial ized

Hello Daniel,

-----Original Message-----
From: Daniel Veillard [mailto:veillard redhat com]
Sent: Friday, September 19, 2003 3:14 PM
To: Keim, Markus
Subject: Re: Your message to xml awaits moderator approval

On Fri, Sep 19, 2003 at 03:10:11PM +0200, Keim, Markus wrote:
Oh, i've definitely not subscribed as markus.keim...,
i never use dots in email addresses. I never even know
that our mail server exposes this address.
Plz excuse...
Should i resend the patch in my previous mail?

  No I got it, but check that I replied, I really busy right now
and may not have time to review it before monday, and then
I might forget about it :-\

Seems it's get out of sight, so here we go again... :]

Hello Daniel, hello @all,

the libxml2 function "xmlRegisterOutputCallbacks()" doesn't
(re-)set the flag "xmlOutputCallbackInitialized" when called.
So, if you clear the "xmlOutputCallbackTable" to solely use
user defined callbacks and register them via
"xmlRegisterOutputCallbacks()", a subsequent call to an
output callback (e.g. "xmlOutputBufferCreate()") will
re-register (and use) the default callbacks instead of the
user defined ones.
Same for "xmlRegisterInputCallbacks()".

I guess this behaviour isn't intended, the attached patch
would fix it, by the way it removes two unecessary (redundant)
lines of code. It's against xmlIO.c, CVS revision 1.113.

Ciao, Markus

Mit freundlichen Gruessen - Kind regards
Markus Keim

________________________Addressed by:________________________
 ORDAT GmbH & Co. KG  -  Serversystems / eCom 
 Dipl.-Inf. (FH) Markus Keim   Fon: +49 (641) 7941-0
 Rathenaustr. 1                Fax: +49 (641) 7941-132
 35394 Gießen                  mailto:markus_keim ordat com
 See:                          http://www.ordat.com
I love deadlines. I like the whooshing sound they make as
they fly by.  -- Douglas Adams

Attachment: xmlIO.diff
Description: Binary data

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]