Re: [xml] [PATCH] Character encodng cleanup

On Wed, Jul 30, 2003 at 01:43:00PM +0200, Peter Jacobi wrote:
Content-Description: Mail message body
Hi Daniel,

I fully agree with these goals:

I think it then becomes the best combination:
    - no code duplication with iconv internal routines if present.
    - allow native support of the full set on all platforms
    - doesn't change the API/ABI

The changed patch is attached. Native ISO-8859-2..ISO-8859-16
support will only be compiled in, when LIBXML_ICONV_ENABLED is
not defined and LIBXML_ISO8859X_ENABLED is defined.

  Okay, this looks good. I applied the patch (excelt the xslt/xml 
change which was there already) and added the necessary cruft needed
to interface it at the configure level. I also changed the 
xmlwinconfig.h so that LIBXML_ISO8859X_ENABLED is defined by default
which seems the right approach on Windows. Excerpt from 
configure --help:

  --with-iconv[=DIR]      add ICONV support (on)
  --with-iso8859x         add ISO8859X support if no iconv (on)

  I have committed this to CVS, it would be a good idea to get this
tested, especially on Windows :-)

  thanks a lot,


Daniel Veillard      | Red Hat Network
veillard redhat com  | libxml GNOME XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]