Re: [xml] tracking libxml's internal node creation / destruction?

[Daniel Veillard <veillard redhat com>]

On Thu, Jan 02, 2003 at 10:07:38AM +0100, Lukas Schroeder wrote:
> On Wed, Jan 01, 2003 at 03:56:21PM -0500, Daniel Veillard wrote:
> > number of places in the code where objects may be allocated or deallocated
> > which won't generate the expected callback. I don't have the time right
> > now to track those holes. Since both of you are interested in this issue
> > I welcome further patches adding the callbacks in the places missing it.
>
> i'll definately do further work in this now that the first step is
> taken.

  Okay, note that I had to rollback the following part of the initial
patch since it was breaking the regression tests:

*** tree.c      1 Jan 2003 20:59:37 -0000       1.233
--- tree.c      1 Jan 2003 21:06:49 -0000       1.234
***************
*** 2452,2459 ****
      /*
       * add the first element at the end of the children list.
       */
-     if (cur->parent == parent)
-       return(cur);

      if (parent->children == NULL) {
          parent->children = cur;
--- 2452,2457 ----

  I found it relatively easilly, that optimization is unsafe.

Daniel

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/