[xml] libxml2-python-2.5.0: debugging output forgotten into production library



Hello,

The debugging output left in libxml2-python-2.5.0's libxml_xmlNewNode()
is causing lots of problems for our project. Even with debugging on,
it would be nicer if all debugging went to stderr instead of stdout.
(printf(..) -> fprintf(stderr,..))

Here's a nice small diff to fix the more immediate NewNode problem:


*** libxml.c    Mon Feb  3 03:08:37 2003
--- libxml.c.orig       Mon Feb  3 03:08:10 2003
***************
*** 2163,2171 ****
      if (!PyArg_ParseTuple(args, (char *) "s:xmlNewNode", &name))
          return (NULL);
      node = (xmlNodePtr) xmlNewNode(NULL, name);
- #ifdef DEBUG
      printf("NewNode: %s : %p\n", name, (void *) node);
- #endif
  
      if (node == NULL) {
          Py_INCREF(Py_None);
--- 2163,2169 ----


And this onto the wishlist: please make the interface one layered.
This two layered system is not nice when we're trying to make a
system where both C++ and Python code needs to access the same
libxml2 objects.

--
        Aleksi Suhonen

        PS. I'd like to see this fix especially on Debian Unstable
        as that is what we're developing on.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]