[xml] A Path Of No Return



Hi there,

While compiling the function xmlSchemaValidatePredefinedType in
xmlschemastypes.c, the compiler said that not all execution paths return a
value. The compiler declared it as a warning and proceeded to build the
executable.

Indeed, this could be a cause for a crash at runtime. Would the following
patch be okay for now?


RCS file: /cvs/gnome/gnome-xml/xmlschemastypes.c,v
retrieving revision 1.8
diff -c -r1.8 xmlschemastypes.c
*** xmlschemastypes.c   16 Sep 2002 10:51:37 -0000      1.8
--- xmlschemastypes.c   20 Sep 2002 13:20:13 -0000
***************
*** 1094,1100 ****
--- 1094,1103 ----
            }
            frac = cur - tmp;
        }
+       return(0);
      } else if (type == xmlSchemaTypeDoubleDef) {
+       TODO
+       return(0);
      } else {
        TODO
        return(0);


Ciao
Igor




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]