Re: [xml] Re: [xslt] Windows build



On Wed, 2002-10-02 at 09:19, Elizabeth Barham wrote:
The pragma seems specific for MSVC but all Win32 platforms are going
to need winsock2.h I didn't check the time info out to much, though.

Well, except cygwin, it doesn't need winsock for user apps. cygwin1.dll
grabs winsock if/when needed.
 
* include/libxml/xmlversion.h.in:
Oh Gods... #if (defined(_MSC_VER) || defined(__CYGWIN__) ||
defined(__MINGW32__))... who is the next? :-) Lets exchange that for a
simple #if defined(__WIN32__), okay, everyone?

Sounds good to me.

Errm, I missed this before. 
The presence of __CYGWIN__ does NOT imply __WIN32__. So 
#if defined(__WIN32__) will break some cygwin builds. Please use
#if defined(__WIN32__) || defined(__CYGWIN__)
 
Rob




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]