Re: Review: FULLSCREEN_MONITORS Hint

[Lubos Lunak <l lunak suse cz>]

On Wednesday 28 of November 2007, Grant Patterson wrote:
> Here's an updated patch; I tried taking most suggestions into  
> account. Kept it as a message/property for now, though that could  
> change.
>
> On Nov 25, 2007, at 10:57 a, Havoc Pennington wrote:
> > Another thing to address, I believe the Xinerama config can now  
> > change dynamically... what happens then? (I'm not sure, to be  
> > honest, what the plans are in this area from X.org)
>
> I'd say the best thing to do would be to clear the property,  
> reverting to "traditional" fullscreen. The client window would be  
> expected to give a new request when it learns about the Xinerama  
> change. Preserving the property in any way would just make things wacky.
>
> On the other hand, if this hint wound up being in terms of a root  
> window geometry, more burden would be on the client to listen to  
> Xinerama changes and respond accordingly.

 I think the best way here would be doing nothing special. That is, just like 
with normal fullscreened window the WM would possibly adjust the geometry to 
fit, it would do the same here. If a client for some reason would want to 
alter the setup, it can do so when detecting the config change (which means 
it has to live for a moment with geometry it doesn't want, but it has to 
handle that anyway).

 The only problem may be that the property might be temporarily out-of-sync 
with reality (e.g. non-existent monitor). Which is yet another reason why I 
don't like to use the property for keeping the state.

 Also, on a related note, it might make sense to have e.g. -1 as value 
meaning "all monitors", so that e.g. video players don't have to handle all 
the details related to this manually.

> On Nov 26, 2007, at 8:27 a, Lubos Lunak wrote:
> > On Thursday 22 of November 2007, Grant Patterson wrote:
> >> A read-only list of monitor indeces indicating which monitors the  
> >> window
> >> should stretch over when fullscreened. The window must cover the  
> >> union of
> >
> >  "The window should" - this is a request to the WM and there's no  
> > guarantee it
> > will honour it.
>
> But here we're talking about the read-only property, which must be in  
> sync with the window's actual geometry--not the client request.

 I see. I didn't (and still don't) see any point in having another property 
announcing something that's obvious to those few that might possibly care. I 
don't find this property to carry any useful information.

 However, I overlooked the source indication field in the message, which makes 
sense, to distinguish between pagers and apps. Therefore I now support the 
message.

>        <para>
> An empty list indicates that the Window Manager will obey normal  
> fullscreen
> conventions, as if the property did not exist.

 I'd cut this paragraph here,

> ; that is, the window   
> will be
> stretched over the monitor it was in when it entered fullscreen.

 as this is unnecessary specifying of what the WM's policy should be.

>        </para>
...

 Other than that, I'm ok with the rest.
 
-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l lunak suse cz , l lunak kde org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz