Re: one draft comment



On Thu, 2002-09-12 at 04:33, Havoc Pennington wrote:
> 
> Hi,
> 
> For _NET_MOVERESIZE_WINDOW I think we need a way to only move or only
> resize, otherwise you have a race condition where you could
> inadvertently resize while trying to only move, or vice versa.
> 
> The easiest thing is probably _NET_MOVE_WINDOW, _NET_RESIZE_WINDOW,
> and _NET_MOVERESIZE_WINDOW as three messages? or data.l[0] could have
> flags |'d into the high bits maybe. Hrm, don't know about that last
> idea.
> 

Yes, its ugly, proposed patch attached. If you consider it too ugly,
we could switch to format 16, giving us 10 fields. But this would be
inconsistent with all the other properties and messages which use 
format 32 (ICCCM properties too), so I guess I like the |flags approach
better. 

Matthias
Index: wm-spec.sgml
===================================================================
RCS file: /home/freedesktop/wm-spec/wm-spec.sgml,v
retrieving revision 1.23
diff -u -b -B -p -r1.23 wm-spec.sgml
--- wm-spec.sgml	7 Sep 2002 18:02:32 -0000	1.23
+++ wm-spec.sgml	13 Sep 2002 23:03:24 -0000
@@ -641,12 +641,21 @@ _NET_MOVERESIZE_WINDOW
   window = window to be moved or resized
   message_type = _NET_MOVERESIZE_WINDOW
   format = 32
-  data.l[0] = gravity
+  data.l[0] = gravity and flags 
   data.l[1] = x
   data.l[2] = y
   data.l[3] = width
   data.l[4] = height
 ]]></programlisting>
+        <para>
+        The low byte of data.l[0] contains the gravity to use; it may contain 
+	any value allowed for the WM_SIZE_HINTS.win_gravity property:
+	NorthWest (1), North (2), NorthEast (3), West (4), Center (5), East
+	(6), SouthWest (7), South (8), SouthEast (9) and Static (10). A 
+	gravity of 0 indicates that the Window Manager should use the gravity
+	specified in WM_SIZE_HINTS.win_gravity. The bits 8 to 11 indicate the
+	presence of x, y, width and height. 
+        </para>
 	<para>
 	Pagers wanting to move or resize a window may send a
 	_NET_MOVERESIZE_WINDOW client message request to the root window


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]