Comments on 1.0pre3

[Sasha_Vasko osca state mo us]

> ---------------
>
> I have to start by saying I think you guys did an excellent job - there's
> hardly a single issue I can find in 1.0pre3:
>
> -       I think section 4.5 should start "A list of hints describing the
>        state of a window".
>
> -       I really like the _NET_WM_PING protocol and I'm sorry we didn't
>        think of it the first time round.
>
> -       I agree with section 6.3 - its really an omission from the ICCCM
>         more than a violation.  We should have specified the corner cases
>         as well as the normal one.
>
> -       Section 6.7 seems to be correct.  This is an important
>         clarification.

Heh, Unfortunately it is not entirely correct (I have to admit - my fault).

It states :

   XMoveWindow(w,x,y) behaviour depends on the window gravity :

And then goes on to describe where window frame will be placed as the
result,
for different gravities. But All following descriptions use (x,y) of the
reference point,
not the (x,y) requested in XMoveWindow.

It should be changed like so :

   XMoveWindow(w,x,y) behaviour depends on the window gravity. Upon
receiving
request from client application Window Manager calculates new reference
point, based
on client window's own size, border width and gravity. For given client
window
dimentions (width, height) and border width (bw), reference point will be
placed at :

Gravity        ref_x               ref_y
___________________________________________

StaticGravity  x              y
NorthWestGravity    x-bw           y-bw
NorthGravity        x+(width/2)          y-bw
NorthEastGravity    x+width+bw           y-bw
EastGravity         x+width+bw           y+(height/2)
SouthEastGravity    x+width+bw           y+height+bw
SouthGravity        x+(width/2)          y+height+bw
SouthWestGravity    x-bw           y+height+bw
WestGravity         x-bw           y+(height/2)
CenterGravity  x+(width/2)         y+(height/2)

After that Window manager will use calculated reference point withou
changes,
untill next XMoveWindow request. Window Manager will place frame
decorations
in the folowing position, based on gravity :

StaticGravity:

window's left top corner will be placed at (ref_x,ref_y)

NorthWestGravity:

window frame's left top corner will be placed at (ref_x,ref_y)

NorthGravity:

window frame's top side's center will be placed at (ref_x,ref_y)

NorthEastGravity:

window frame's right top corner will be placed at (ref_x,ref_y)

EastGravity:

window frame's right side's center will be placed at (ref_x,ref_y)

SouthWestGravity:

window frame's left bottom corner will be placed at (ref_x,ref_y)

SouthGravity:

window frame's bottom side's center will be placed at (ref_x,ref_y)

SouthEastGravity:

window frame's right bottom corner will be placed at (ref_x,ref_y)

WestGravity:

window frame's left side's center will be placed at (ref_x,ref_y)

CenterGravity:

window frame's center will be placed at (ref_x,ref_y)


>
> -       I think section 6.8's first sentence should read "windows that
>         are a part of a Window-in-Window MDI".
>
> Sorry this took a few days.
>
>         David.
>

Regards

Sasha Vasko