[Vala] [PATCH] Tiny patch regarding gdk-x11 vapi.



I am dealing with the new x11 binding and a few things (trying to port
a System Tray manager to Vala) and I found that there is (what I
believe to be) a tiny mistake in gdk-x11 vapi files.

Gdk.x11_screen_get_xscreen is returning a Gdk.Screen, where it should
return a X.Screen, so I'm sending you the simplest patch possible:
changing Gdk to X

--- gdk-x11-2.0.vapi    2009-05-30 17:45:47.000000000 -0300
+++ /home/alexandream/temp.vapi 2009-05-30 18:20:16.000000000 -0300
@@ -71,7 +71,7 @@
        [CCode (cheader_filename = "gdk/gdkx.h")]
        public static unowned string x11_screen_get_window_manager_name
(Gdk.Screen screen);
        [CCode (cheader_filename = "gdk/gdkx.h")]
-       public static unowned Gdk.Screen x11_screen_get_xscreen (Gdk.Screen screen);
+       public static unowned X.Screen x11_screen_get_xscreen (Gdk.Screen screen);
        [CCode (cheader_filename = "gdk/gdkx.h")]
        public static unowned Gdk.Visual x11_screen_lookup_visual
(Gdk.Screen screen, uint32 xvisualid);
        [CCode (cheader_filename = "gdk/gdkx.h")]



I hope this helps. Unfortunately I don't know enough of Vala yet to
make sure this is the only change necessary (Is it possible to return
X.Screen in an owned way? Does it have a copy method to call?), so, if
you guys have further changes to apply regarding this method, please
let me know so I can patch my own version.

Best Regards,
Alexandre Moreira.

PS: I've been checking in and out of Vala for the past two or three
years, and I admit I disagreed with many things you guys did in the
beginning of the project. Well, here I am to say I was wrong! The
visions you had in the beginning are now showing what has a good
chance of becoming a great language to develop to the Gtk+/GNOME
platform and I just love it!

Keep up the great work, guys, because it's definitely worth it.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]