[Vala] -o on windows + mingw



Hello,
since gnome's bugzilla doesn't seem to work right now, here's the problem:

on windows + mingw, spawn_command_line_sync() fails because pkgconfig output contains a trailing enter (that gets concatenated in the command) and because the output of --libs must go last.
Attached is the trivial patch.
-- 
Vlad 
Index: gobject/valaccodecompiler.vala
===================================================================
--- gobject/valaccodecompiler.vala      (revision 1144)
+++ gobject/valaccodecompiler.vala      (working copy)
@@ -93,7 +93,7 @@
                        }
                        cmdline += " -o " + Shell.quote (output);
                }
-               cmdline += " " + pkgflags;
+
                if (cc_options != null) {
                        foreach (string cc_option in cc_options) {
                                cmdline += " " + cc_option;
@@ -117,6 +117,8 @@
                        cmdline += " " + Shell.quote (file);
                }
 
+               cmdline += " " + pkgflags.strip ();
+
                try {
                        Process.spawn_command_line_sync (cmdline, null, null, out exit_status);
                        if (exit_status != 0) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]