Re: [Vala] Small patches and some questions

[Jürg Billeter <j bitron ch>]

Hi Hessu,

On Die, 2006-10-31 at 13:13 +0200, Heikki Paajanen wrote:
> I've also run into few minor issues.
>
> size_allocate -signal:
>
> GtkAllocation seemed to be missing, patch attached
> (gtk_vapi_allocation.patch).
>
> GdkDrawable:
>
> Some of the gdk drawable functions are generated as gdk_drawable_draw_* but
> they seem to defined as gdk_draw_*. Attached patch (gdk_vapi_drawable.patch)
> fixes atleast some of them. Is there are better way to do this than to use
> CCode(cname==)?
>
>
> Please let me know if there's something wrong with these patches, this is my
> first try :)

Thanks for the patches, both seem to be correct. You shouldn't directly
modify the VAPI files for GTK+, though, as they have been generated by
vapigen, so we should fix vapigen to generate better VAPI files.

> Also I noticed that Gdk.Pixmap does not extend Gdk.Drawable and so if I have
> for example a pixmap I have to use the methods of Drawable with casts
> "((Gdk.Drawable)pixmap).draw_pixbuf" instead of calling it directly. Is this
> intentional?

No, that's also a bug in vapigen.

I'll fix the issues as soon as possible, thanks for your report.

Regards,

Jürg