[Usability] Patch for #64800



This patch fixes bug #64800. It reverts to the old behavior of having
the preview label widget under the map area.

-- dobey

? widgets/e-timezone-dialog/e-timezone-dialog.gladep
Index: widgets/e-timezone-dialog/e-timezone-dialog.c
===================================================================
RCS file: /cvs/gnome/evolution/widgets/e-timezone-dialog/e-timezone-dialog.c,v
retrieving revision 1.14
diff -u -p -r1.14 e-timezone-dialog.c
--- widgets/e-timezone-dialog/e-timezone-dialog.c	17 Aug 2004 14:15:21 -0000	1.14
+++ widgets/e-timezone-dialog/e-timezone-dialog.c	10 Sep 2004 16:53:24 -0000
@@ -59,6 +59,7 @@ struct _ETimezoneDialogPrivate {
 	GtkWidget *table;
 	GtkWidget *map_window;
 	GtkWidget *timezone_combo;
+	GtkWidget *preview_label;
 };
 
 
@@ -296,11 +297,13 @@ get_widgets (ETimezoneDialog *etd)
 	priv->map_window	= GW ("map-window");
 	priv->timezone_combo	= GW ("timezone-combo");
 	priv->table             = GW ("timezone-table");
+	priv->preview_label     = GW ("preview-label");
 
 	return (priv->app
 		&& priv->map_window
 		&& priv->timezone_combo
-		&& priv->table);
+		&& priv->table
+		&& priv->preview_label);
 }
 
 
@@ -321,7 +324,6 @@ e_timezone_dialog_new (void)
 	return e_timezone_dialog_construct (E_TIMEZONE_DIALOG (etd));
 }
 
-
 static const char *
 zone_display_name (icaltimezone *zone)
 {
@@ -387,7 +389,7 @@ on_map_motion (GtkWidget *widget, GdkEve
 
 	new_zone = get_zone_from_point (etd, priv->point_hover);
 
-	gtk_entry_set_text (GTK_ENTRY (GTK_COMBO (priv->timezone_combo)->entry),
+	gtk_label_set_text (GTK_LABEL (priv->preview_label),
 			    zone_display_name (new_zone));
 
 	return TRUE;
@@ -568,6 +570,8 @@ e_timezone_dialog_set_timezone (ETimezon
 
 	priv->zone = zone;
 
+	gtk_label_set_text (GTK_LABEL (priv->preview_label),
+			    zone ? zone_display_name (zone) : "");
 	gtk_entry_set_text (GTK_ENTRY (GTK_COMBO (priv->timezone_combo)->entry),
 			    zone ? zone_display_name (zone) : "");
 
Index: widgets/e-timezone-dialog/e-timezone-dialog.glade
===================================================================
RCS file: /cvs/gnome/evolution/widgets/e-timezone-dialog/e-timezone-dialog.glade,v
retrieving revision 1.6
diff -u -p -r1.6 e-timezone-dialog.glade
--- widgets/e-timezone-dialog/e-timezone-dialog.glade	14 Apr 2004 21:30:54 -0000	1.6
+++ widgets/e-timezone-dialog/e-timezone-dialog.glade	10 Sep 2004 16:53:24 -0000
@@ -13,6 +13,11 @@
   <property name="default_height">400</property>
   <property name="resizable">True</property>
   <property name="destroy_with_parent">False</property>
+  <property name="decorated">True</property>
+  <property name="skip_taskbar_hint">False</property>
+  <property name="skip_pager_hint">False</property>
+  <property name="type_hint">GDK_WINDOW_TYPE_HINT_DIALOG</property>
+  <property name="gravity">GDK_GRAVITY_NORTH_WEST</property>
   <property name="has_separator">False</property>
 
   <child internal-child="vbox">
@@ -34,6 +39,7 @@
 	      <property name="label">gtk-cancel</property>
 	      <property name="use_stock">True</property>
 	      <property name="relief">GTK_RELIEF_NORMAL</property>
+	      <property name="focus_on_click">True</property>
 	      <property name="response_id">-2</property>
 	    </widget>
 	  </child>
@@ -47,6 +53,7 @@
 	      <property name="label">gtk-ok</property>
 	      <property name="use_stock">True</property>
 	      <property name="relief">GTK_RELIEF_NORMAL</property>
+	      <property name="focus_on_click">True</property>
 	      <property name="response_id">-3</property>
 	    </widget>
 	  </child>
@@ -167,16 +174,50 @@ Use the right mouse button to zoom out.<
 	      </child>
 
 	      <child>
-		<widget class="GtkScrolledWindow" id="map-window">
+		<widget class="GtkVBox" id="vbox1">
 		  <property name="visible">True</property>
-		  <property name="can_focus">True</property>
-		  <property name="hscrollbar_policy">GTK_POLICY_ALWAYS</property>
-		  <property name="vscrollbar_policy">GTK_POLICY_ALWAYS</property>
-		  <property name="shadow_type">GTK_SHADOW_IN</property>
-		  <property name="window_placement">GTK_CORNER_TOP_LEFT</property>
+		  <property name="homogeneous">False</property>
+		  <property name="spacing">6</property>
 
 		  <child>
-		    <placeholder/>
+		    <widget class="GtkScrolledWindow" id="map-window">
+		      <property name="visible">True</property>
+		      <property name="can_focus">True</property>
+		      <property name="hscrollbar_policy">GTK_POLICY_ALWAYS</property>
+		      <property name="vscrollbar_policy">GTK_POLICY_ALWAYS</property>
+		      <property name="shadow_type">GTK_SHADOW_IN</property>
+		      <property name="window_placement">GTK_CORNER_TOP_LEFT</property>
+
+		      <child>
+			<placeholder/>
+		      </child>
+		    </widget>
+		    <packing>
+		      <property name="padding">0</property>
+		      <property name="expand">True</property>
+		      <property name="fill">True</property>
+		    </packing>
+		  </child>
+
+		  <child>
+		    <widget class="GtkLabel" id="preview-label">
+		      <property name="visible">True</property>
+		      <property name="label" translatable="yes">America/New_York</property>
+		      <property name="use_underline">False</property>
+		      <property name="use_markup">False</property>
+		      <property name="justify">GTK_JUSTIFY_LEFT</property>
+		      <property name="wrap">False</property>
+		      <property name="selectable">False</property>
+		      <property name="xalign">0</property>
+		      <property name="yalign">0.5</property>
+		      <property name="xpad">0</property>
+		      <property name="ypad">0</property>
+		    </widget>
+		    <packing>
+		      <property name="padding">0</property>
+		      <property name="expand">False</property>
+		      <property name="fill">False</property>
+		    </packing>
 		  </child>
 		</widget>
 		<packing>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]