Re: Comments on dialog proposal

[Maciej Stachowiak <mjs noisehavoc org>]

On 02Sep2001 09:48AM (-0700), Seth Nickell wrote:
> Nils and I discussed this and length with respect to Control Center
> preference panes. We propose:
> 
>     [Help]              [Undo][Done]
> 
> Help is optional and is placed on the left-hand-side. Undo only undoes
> the last change. Revert is a more complicated concept, and one that
> users are not as familiar with as undo, so we're stealing a page from
> the edit menu. Of course, all changes in such a dialogue should be
> instant. As with the existing menu proposal, the default option is on
> the rhs.
> 
> For the sake of discussion, Adam prefers:
> 
>     [Help]             [Undo][Close]
> 
> I (and nils I believe) favour the former because "Close" sounds
> potentially destructive, whereas Done emphasizes that the changes made
> will not be lost. Adam prefers "Close" because it specifies what will
> actually happen [to the window] when the button is clicked, and thus is
> more literal/accurate.

I would tend to prefer Close. I don't think it sounds destructive -
the general implication of "Close" is "close this dialog and do
nothing else". 

I would also suggest leaving out "Undo", especially if it undoes only
one change. Undoing a click on a checkbox, a radio button or a list by
clicking an "Undo" button is extremely silly. Controls that accept
more free-form values (text you type in, a color you select) should
make it convenient to go back to recently chosen values (for text you
could use GnomeEntry for instance). Given all that, an "Undo" button
becomes superfluous.

If it is left in, however, and we want to follow the Mac-style button
ordering, I'd suggest a space between "Undo" and "Close" since "Undo"
is an alternative action, not a negative response.

BTW, where in CVS is the proposal, and should I feel free to apply
changes to it that appear non-controversial on this list?

 - Maciej