Re: [Tracker] Request for review, jolla upstreaming

[Philip Van Hoof <philip codeminded be>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martyn Russell schreef op 12/03/2014 13:24:
> On 12/03/14 09:37, Philip Van Hoof wrote:

> Apparently, GIFLIB_MAJOR is only defined in version 4.2, wouldn't
> it make more sense to have:
>
> #ifdef GLIB_MAJOR ... #else PrintGifError() #endif
>
> ?

> Er, GIFLIB rather

I'll look into this.


> Cool to have a BMP extractor. Though you leak filename in the
> extractor and that needs fixing first.

ok


> The fallbacks for BMP on master should do the basics of what your
> patch does here (i.e. fill in Photo/Image ontology details) -
> detailed in the xml files.

Aha, didn't know about fallbacks yet. But it's good to have the basics
for a bmp extractor ready. Hoping that somebody fills in actual
metadata extraction ;-)

I'll fix the memory leak.

> All other patches/changes look ok to me.
>
> Thanks Philip,

No problem.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTIFe2AAoJEEP2NSGEz4aDLU8H/0mWgK6GAvhpcP95rivTACXr
YQNWJr85vWOrQrYXvFeXE9Lh9ZOKY7FAx2AGdXkI8yW8F5Ma87Qd+2MInoc5PMNg
aeFz/rrnAfv6ktsV3p1HmPMSseDbDKTCYPC9Mje/SnFaJcr9f9PV46pSkMG/L3cu
MDy+8fNfJg1Fn4a5+tvtf6my3Hl4Dq4mJbpE1jIEHyXoR+s0uoTtUXZL+yHPNGey
dXpJ4CSLO/khdw7U8o+MwHlExPca4wLEnep2/WsRQUC9YGvwlYVufqVdC6Zknaf7
dxxIL1hoGefyxmnKU3J1qrwOA1dOmJP3vosXogvY83vkdXYDolBaheX6oEtGobQ=
=AQnX
-----END PGP SIGNATURE-----