Re: [Tracker] Request for review, jolla upstreaming

[Philip Van Hoof <philip codeminded be>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martyn Russell schreef op 12/03/2014 13:28:
> On 12/03/14 12:24, Martyn Russell wrote:
> > OK, so it looks like this is just about disabling enca AND icu
> > for MP3 encoding detection. The existing code already does the
> > same thing when we have enca and/or icu. Is that right or? If so,
> > it looks good to me.
>
> To clarify: I meant that you can't disable icu for mp3 encoding
> ONLY, you can only disable icu for EVERYTHING currently. You want
> this patch to disable icu for mp3 encoding guessing only right?
>
> IF so, it looks good to me.

Right. That's the point: enable libicu but disable (just) its charset
encoding detection.

Kind regards,

Philip
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTIFcyAAoJEEP2NSGEz4aDkzkH/2NezPOcFZLG+10FBarYG2wN
g/eSqGF5Hbc0lsqKoejGescVYpRYgg2Az9SDPhxEr249RnV9LVq1C+LzpI4T+Oyv
I0COst5fGR4GQ+0N5pv5gsRs7yXZuowvHF+KXFiGG3nja4dfLrYiaU46zN+cgifm
OA46mgV0+FS9jISYp7/s6WeJpKYCcskHOPoH8h9Ngz9xenewZEJfrPBfBvl+IrhF
RnO0razCEPPxiBV/ukbARt3iGjcnlFKB4bKfOsXgocXb7CSHiTe5dGDbw0Rovtwi
Hc4VR//Y1QJU9HqszkiqU9d4ud3Hl22s2hchXfLqji126SJwfM5adTSZGGgQfMA=
=Gvod
-----END PGP SIGNATURE-----