Re: [Tracker] Review request, bug fixed by a downstream integrator (Jolla)

[Philip Van Hoof <philip codeminded be>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Hi Martyn,

This is a comment by developer a from the bug:

"

tracker-control -s starts tracker (which fails because it is already
re/started by systemd).

I was able to reproduce this with some minimal steps :

[nemo Jolla Camera]$ cp ../x_files_12.jpg .
[nemo Jolla Camera]$ tracker-search -i 2>/dev/null | wc -l
479
[nemo Jolla Camera]$ tracker-search -i 2>/dev/null | wc -l
480
[nemo Jolla Camera]$ systemctl --user restart tracker-miner-fs.service
[nemo Jolla Camera]$ tracker-control -F
Store:
27 Jun 2014, 13:21:25: ? Store - Idle

Miners:
27 Jun 2014, 13:21:25: 68% File System - Processing? unknown time left
27 Jun 2014, 13:21:25: ? Extractor - Idle
27 Jun 2014, 13:21:25: ? Applications - Not running or is a disabled
plugin
Press Ctrl+C to end follow of Tracker state
27 Jun 2014, 13:21:29: 72% File System - Processing? unknown time left
27 Jun 2014, 13:21:30: 83% File System - Processing? unknown time left
27 Jun 2014, 13:21:35: 87% File System - Processing? unknown time left
27 Jun 2014, 13:21:36: 98% File System - Processing? unknown time left
27 Jun 2014, 13:21:40: ? File System - Idle
27 Jun 2014, 13:21:42: ? File System - Processing?
27 Jun 2014, 13:21:42: ? File System - Idle
^C
Received signal:2->'Interrupt'
[nemo Jolla Camera]$ tracker-search -i 2>/dev/null | wc -l
60


This is still reproducible on latest upstream release 1.0.1 and master
( but fixes a lot of other potential crashes ).

Reverting [1] fixes this scenario. That commit was implemented for us
in bug 16427

[1]
https://git.gnome.org/browse/tracker/commit/?id=243c97fa96a2f6b19bce1acf26946d1a516a0a1c


"

And then a comment from Richard Braakman (developer b, committer of
the fix in github):

"

Ok, I looked at that commit and I see what's going wrong but not yet
how to fix it.

The error is around line 715,
  /* Updated directories have been found, check for deleted contents
in those */

The code that follows will compare the store contents against the
contents reported by the recent crawler run. However, the crawler
results don't contain the subdir's contents, because it was called
with a max depth of 1. So it's going to emit "deleted" signals for all
of the store contents.

I'm going to think about what this code should be doing instead.

"

The next comment on the bug was the pull request and fix :)





On 10/07/2014 12:30, Martyn Russell wrote:
> On 08/07/14 08:48, Philip Van Hoof wrote:
> > -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
> >
> > Hi guys,
>
> Hi Philippe,
>
> > As you know I'm tailing the Tracker package for the Jolla device 
> > and I noticed that there a bugfix was made by Richard Braakman 
> > for a change that happened recently:
> >
> > https://github.com/nemomobile-packages/tracker/pull/29
> >
> > Commit here: 
> > https://github.com/amtep/tracker/commit/419d680619b5e0d4f3ae308a087dd313e8ce252e
>
> >
> Thanks for the patch details here.
>
> > Place where it got introduced (adding Carlos in CC for review):
> >
> > https://git.gnome.org/browse/tracker/commit/?id=243c97fa96a2f6b19bce1acf26946d1a516a0a1c
>
> >
> I've spent some time reviewing the patch.
>
> Presumably by "leveled notification" amtep means save level in the
>  tree/directory structure.
>
> Presumably "bottom of the crawler search results" means last 
> "deepest ancestor" in a directory structure, not child/children at 
> the same level of the tree (from his commit comment)?
>
> The exact details of the situation here would help us identifier
> if this is the right place for the fix at least and also for
> testing purposes.
>
> Saying all that, looking at the fix, it certainly looks like the 
> right solution and probably in the right place too, but I would 
> prefer to have more details to test and be sure (i'm sure Carlos 
> would too).
>
> Is the author available to talk to us on IRC or reply here? Thanks 
> Philip,

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTvnSoAAoJEEP2NSGEz4aDMiIH+waBcXWTu8zvDkE9XaR7yxHl
c1DBheZRlUIL45TjBPwtQaCJJqvIWHQXMEbIdJ5wG+joG50ULA9FDLL4qjTWgOul
AclmvzESu7ZOoJntRJMc/Tifgp3gPFKjeuE3+0nrASIoaBndEW9uSHSZmau63F4L
1nLpzU4eDKsFaX+QxUUK79H87hLlKHEJoQt+tlAa9KqwtSU+9VHKL3j2mXaL7wI5
vX6Td7SfO5Io51fs9Ob2Tw88lJDmNs8GehFABSxk6LA8BcZWq69cEnoEw01+l2ic
vO/t/nP+/DGB/AkDIBu+6nq69bbtufQMbVGieQmBBHIOQtU8lTfy/cdiL5iQ11I=
=hHM3
-----END PGP SIGNATURE-----