Re: [Tracker] Review request, bug fixed by a downstream integrator (Jolla)

[Martyn Russell <martyn lanedo com>]

On 08/07/14 08:48, Philip Van Hoof wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi guys,

Hi Philippe,

> As you know I'm tailing the Tracker package for the Jolla device and I
> noticed that there a bugfix was made by Richard Braakman for a change
> that happened recently:
>
> https://github.com/nemomobile-packages/tracker/pull/29
>
> Commit here:
> https://github.com/amtep/tracker/commit/419d680619b5e0d4f3ae308a087dd313e8ce252e

Thanks for the patch details here.

> Place where it got introduced (adding Carlos in CC for review):
>
> https://git.gnome.org/browse/tracker/commit/?id=243c97fa96a2f6b19bce1acf26946d1a516a0a1c

I've spent some time reviewing the patch.

Presumably by "leveled notification" amtep means save level in the 
tree/directory structure.

Presumably "bottom of the crawler search results" means last "deepest 
ancestor" in a directory structure, not child/children at the same level 
of the tree (from his commit comment)?

The exact details of the situation here would help us identifier if this 
is the right place for the fix at least and also for testing purposes.

Saying all that, looking at the fix, it certainly looks like the right 
solution and probably in the right place too, but I would prefer to have 
more details to test and be sure (i'm sure Carlos would too).

Is the author available to talk to us on IRC or reply here?
Thanks Philip,

--
Regards,
Martyn

Founder & Director @ Lanedo GmbH.
http://www.linkedin.com/in/martynrussell