Re: [Tracker] REVIEW: Xavier Claessens' "priority" branch

[Carlos Garnacho <carlosg gnome org>]

Hey,

Sending this one on-list this time...

On mié, 2014-02-19 at 14:28 -0500, Xavier Claessens wrote:
> Le mercredi 19 février 2014 à 02:00 +0100, Carlos Garnacho a écrit :
> > Hey,
>
> > So from looking at the code, the implementation looks quite correct, and
> > it looks like a positive addition, I just have minor improvements:
>
> \o/
>
> > 0. Nice cleanup to tracker-extract's tracker-config.c, long time
> > overdue :)
>
> Thanks. I think it is the right way of doing it. I copied what
> tracker-miner-fs does. But Martyn wasn't totally sure in his comment:
>   https://bugzilla.gnome.org/show_bug.cgi?id=719802#c26.
>
> Do you confirm it's good?

Forgot to reply to this one...Yeah, I think it looks fine, after all the
GSettings are delayed, and never applied from the running miner, so the
command line switches don't end up in dconf even if the GSettings object
keeps those changes in memory.

The only moment when settings are applied should happen when migrating
from older (ancient by now...) keyfile configurations, and that happens
before the object properties can be modified.

Cheers,
  Carlos