Re: [Tracker] REVIEW: Xavier Claessens' "priority" branch

[Carlos Garnacho <carlosg gnome org>]

Hey Xavier,

On mié, 2014-02-19 at 14:28 -0500, Xavier Claessens wrote:
> Le mercredi 19 février 2014 à 02:00 +0100, Carlos Garnacho a écrit :
> > Hey,
>
> > So from looking at the code, the implementation looks quite correct, and
> > it looks like a positive addition, I just have minor improvements:
>
> \o/
>
> > 0. Nice cleanup to tracker-extract's tracker-config.c, long time
> > overdue :)
>
> Thanks. I think it is the right way of doing it. I copied what
> tracker-miner-fs does. But Martyn wasn't totally sure in his comment:
>   https://bugzilla.gnome.org/show_bug.cgi?id=719802#c26.
>
> Do you confirm it's good?
>
> > 1. tracker_decorator_set_priority_rdf_types() is added, but there's no
> > matching GObject property, would be great to get one.
>
> Hm. I don't keep the strv of rdf types, only a GArray of their ids, so a
> getter is a bit more complex -but not impossible- to write. I'll do that
> if you think it's important.

Hmm, didn't notice that... maybe just make it writeonly at the moment
and we'll care later about fetching the tracker:uri()?, but let's not
block on this I'd say.

<snip>
> Branch updated, top 4 commits fixes each of your comments:
>  http://cgit.collabora.com/git/user/xclaesse/tracker.git/log/?h=priority

I've had a look and it all looks good :)

Cheers,
  Carlos

> Regards,
> Xavier Claessens.