Re: [Tracker] trackerbird fixes

[Adrien Bustany <abustany gnome org>]

Le 06/02/2014 16:40, Martyn Russell a écrit :
> On 06/02/14 10:16, Michael Lipp wrote:
> > Hi,
>
> Hi Michael,
>
> > after being annoyed about the erroneous trackerbird for quite some time,
> > I finally decided to dig myself into it. I couldn't find any
> > corresponding bugs in the bug database. I think, people have given up on
> > this component because it seemed to be unmaintained and thunderbird has
> > its own search facility (but I like the combined search). Or the bugs
> > never reached "upstream" (you find some in the Suse/Ubuntu/Fedora bug
> > trackers).
>
> First, thank you for picking this up!
>
> > I fixed the following problems:
> >
> > 1) Trackerbird doesn't work at all with TB24 due to interface changes.
>
> Yea, I really hate all the number changes making it impossible to keep
> the plugins working in most cases too.
>
> > 2) Thunderbirds sometimes "freezes" when trackerbird is enabled (you
> > find that in a lot of forums and bug trackers, e.g.
> > https://bugzilla.mozilla.org/show_bug.cgi?id=930492)
>
> I see.
>
> > 3) Improved output via dump statements and also added some reporting to
> > the thunderbird console in case you haven't enabled dump. This is only
> > done for some "hot spots", though.
>
> Great! :)
> We love debug.
>
> > If you're interested in merging the changes, you can pull them from
> > https://github.com/mnlipp/tracker.
>
> We certainly are.
>
> > What I don't like yet is that mails are found when searching as Mails
> > but also as "Douments" with "Loading..." being displayed. Going to look
> > into this as well, but I'll have to better understand the data model
> > first.
>
> Yea, there is a bug about this:
>    https://bugzilla.gnome.org/show_bug.cgi?id=696099
>
> I've been meaning to fix it, but I didn't get around to it.
> It should be fairly easy to do, just don't create emails as nfo:Document.

I'm afraid we can't create emails otherwise, as nmo:Message is a 
subclass of nfo:TextDocument. So I might have to look at refining the 
queries in tracker-needle instead?

Cheers

Adrien