Re: [Tracker] REVIEW: Fix Deprecations Branch

[Jonatan Pålsson <jonatan palsson pelagicore com>]

Hi Martyn!

On 6 September 2013 13:36, Martyn Russell <martyn lanedo com> wrote:
> On 06/09/13 10:01, Jonatan Pålsson wrote:
> > Hi!
>
>
> Hi Jonatan,
>
>
> > I tried the code from the fix-deprecations branch, and it seems to be
> > giving me segfaults. Perhaps someone can verify I'm not the only one
> > seeing this?
>
>
> Thanks for testing. I will be honest, I didn't test it yet, I was really
> looking for comments on the approach. I've only made sure it compiles so
> far.
>
>
> > This should reproduce what I'm seeing:
> > tracker-control -r
> > rm -rf ~/.cache/tracker/ ~/.local/share/tracker (The issues seem to be
> > related to building a new database / processing the ontologies)
>
>
> tracker-control -r does this too.
I have a feeling that the "ontologies.gvdb" file influences the
behavior I observed. This may have been my imagination however. This
file is not removed by the tracker-control -r command. By the way, is
this intended, or is tracker-control -r supposed to remove the gvdb
file as well? The manual says -r will remove *databases* - which it
indeed does, but the gvdb file?

As a side note, the tracker-store.ontology.journal file also survives
"tracker-control -r", is this also the intended behavior? Otherwise I
might write up a patch for removing these two files.

> > /usr/local/libexec/tracker-store
> >
> > After these commands, the store should segfault.
> >
> > Also, perhaps related to the crashes;
> > - on line 963 of tracker-data-update.c , should GValueArray actually
> > be a GArray? I believe resource_buffer->predicates is a GArray
> > already, but is assigned the wrong type here. (see line 1371)
>
>
> Great that you noticed this. Did fixing this fix the crashing for you?
> I would accept patches to that branch if you've got the time.

Unfortunately it did not :( I did however get different segfaults, so
it appears to have fixed one of the issues. I may have time to push
some to this branch, but I would like to solve all the segfaults first
(locally on my machine), to ensure the patches are good.

-- 
Regards,
Jonatan Pålsson

Pelagicore AB
Ekelundsgatan 4, 6th floor, SE-411 18 Gothenburg, Sweden