Re: [Tracker] REVIEW: Fix Deprecations Branch

[Martyn Russell <martyn lanedo com>]

On 06/09/13 10:01, Jonatan Pålsson wrote:
> Hi!

Hi Jonatan,

> I tried the code from the fix-deprecations branch, and it seems to be
> giving me segfaults. Perhaps someone can verify I'm not the only one
> seeing this?

Thanks for testing. I will be honest, I didn't test it yet, I was really 
looking for comments on the approach. I've only made sure it compiles so 
far.

> This should reproduce what I'm seeing:
> tracker-control -r
> rm -rf ~/.cache/tracker/ ~/.local/share/tracker (The issues seem to be
> related to building a new database / processing the ontologies)

tracker-control -r does this too.

> /usr/local/libexec/tracker-store
>
> After these commands, the store should segfault.
>
> Also, perhaps related to the crashes;
> - on line 963 of tracker-data-update.c , should GValueArray actually
> be a GArray? I believe resource_buffer->predicates is a GArray
> already, but is assigned the wrong type here. (see line 1371)

Great that you noticed this. Did fixing this fix the crashing for you?
I would accept patches to that branch if you've got the time.

> - If GValueArray is replaced with GArray, the loop on like 974 needs
> to loop over values->len

Indeed. But I would expect a compiler error normally (unless it's a cast 
issue).

> If anyone else sees the segfaults, I'll keep digging, but if not, I
> guess I have something configured horribly wrong :)

Thanks for the testing.

--
Regards,
Martyn

Founder & Director @ Lanedo GmbH.
http://www.linkedin.com/in/martynrussell