Re: [Tracker] [Re: tracker in F16]

[Martyn Russell <martyn lanedo com>]

On 20/09/11 10:11, Philip Van Hoof wrote:
> On Tue, 2011-09-20 at 11:08 +0200, Aleksander Morgado wrote:
> > > I beg your pardon, I just double checked this and there is also a
> > > tracker_file_is_locked() API which only the miner-fs uses in one
> > > instance. That is used when checking each file in our queue handler
> > > function:
> > >
> > >     if (file&&  queue != QUEUE_DELETED&&
> > >         tracker_file_is_locked (file)) {
> > >
> > > I agree, this could potentially be a place to improve. Carlos,
> > > Aleksander, can you guys comment on why we still have this in place?
> >
> > IIRC, those were just to sync with tracker-writeback, which is (was?)
> > the only one usign flock()s. Possibly dead code that can be removed.
>
>
> The writeback feature in master has a bug at this moment, so a bit hard
> to test. But it's true that since its new architecture the flock isn't
> needed anymore, at least as far as I know.

Great, care to remove the check and the unused API before this week's 
0.12.2 release? :)

--
Regards,
Martyn

Founder and CEO of Lanedo GmbH.