Re: [Tracker] RFC: UPnP mediaserver (ContentDirectory) miner



Hi,
   Sorry to bring this long dead thread back to life but I just looked
into the sources of this extractor and found two major issues:

1. 
http://gitorious.org/tracker-upnp/tracker-upnp/blobs/master/src/tracker-miner-upnp-content-directory.vala#line205

   With the unconditional "*" in there, how is search better than
crawling? Actually this is definitely going to have much worse
performance (compared to "crawl") as each request will make the server
search ALL media objects and then send a chunk of it. I strongly
suggest you do not harvest servers that provide proper search (you can
have some simple test to see if its performenant enough). Apart from
performance/scalability issue, another reason to do it this way is
that you don't have a reliable way to ensure sync between MediaServer
hierarchy and local tracker store.

2. 
http://gitorious.org/tracker-upnp/tracker-upnp/blobs/master/src/tracker-miner-upnp-content-directory.vala#line369

  Why check for search caps when you don't use it? :)

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]