Re: [Tracker] review required: rss-enclosures
- From: Martyn Russell <martyn lanedo com>
- To: Michele Tameni <michele tameni it>
- Cc: Tracker mailing list <tracker-list gnome org>
- Subject: Re: [Tracker] review required: rss-enclosures
- Date: Tue, 07 Sep 2010 12:26:34 +0100
On 15/07/10 23:59, Michele Tameni wrote:
Hi all, i've just rebased all the work of Roberto on master, and
squashed some commit for a cleaner tree.
If someone can review... :)
I started to look into the branch briefly, it needs some work. First it
doesn't build using today's master :/
Can you rebase using git rebase origin/master and fix the issues there?
then it will make testing it much easier.
Other than that, generally, source files should have tracker- as a
prefix to the filename/APIs even if they're internal. I noticed your
wrappers don't do that.
I will revisit this review if you can fix those issues first please :)
--
Regards,
Martyn
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]