Re: [Tracker] [PATCH] TST improvements, ...

[Martyn Russell <martyn lanedo com>]

On Wed, 2010-05-05 at 12:29 +0200, Tshepang Lekhonkhobe wrote:
> On Tue, May 4, 2010 at 12:29, Martyn Russell <martyn lanedo com> wrote:
> > > 38 - some clean-ups and consistency fixes (metadata tile)
> >
> > You use '%s' for URIs, please don't we use \"%s\" everywhere else in the
> > code base and also it breaks for URIs which use ' in their name.
> >
> > We usually escape strings too before using them there, but I presume the
> > URI came from Tracker so it should already be escaped.
> >
> > If you can fix those ' vs " issues, I will commit it.
>
> find attached, patch 0005

Thanks, note, you changed the string where you updated the select to
SELECT but not the where to WHERE, please be consistent on this ;)

> > > 39 - fix a segfault
> >
> > Looks good, but doesn't commit due to 0038.

Committed, but please fix whitespace issues before you send patches. You
can do this with:

  git diff --check

Thanks Tshepang,

-- 
Regards,
Martyn