Re: [Tracker] Review request: miner-web-review branch

[Martyn Russell <martyn lanedo com>]

On 17/03/10 18:31, Martyn Russell wrote:
> On 17/03/10 11:30, Martyn Russell wrote:
> > 1. Need more information to understand D-Bus method: GetAssociationData

Understood :)

> > 2. This method AssociationStatus should probably be
> > GetAssociationStatus, more consistent.
>
> I will fix this tomorrow.

Fixed.

> > 22. Why do we need a static mutex in the password provider?

Not sure this is the right way to do this. For now, we can keep it as 
is. The whole singleton thing feels like the wrong way to do this.

> > 34. TrackerMinerWebError needs properly documenting

Fixed.

> > 35. TrackerMinerWebAssociationStatus needs properly documenting

Fixed.

> > 37. TrackerPasswordProviderError and TrackerPasswordProvider need
> > documenting.

Fixed.

--

I think all that we need to fix now is the mlock issue. I will do that next.

--
Regards,
Martyn