[Tracker] Patch to README / configure.ac: -Wno-portability / AC_CHECK_LIB(id3, ID3Tag_New).

[Don Pellegrino <don drexel edu>]

I am working through my first build of tracker from git://git.gnome.org/tracker. I am building on a Debian Sid amd64 system.

First and trivially I noticed a couple of complaints from the build system about the use of GNU specific extensions to Make. Unless there are plans to eliminate use of these extensions it might be cleaner to use the "-Wno-portability" flag to AM_INIT_AUTOMAKE.

Second and more troublesome I found that the AC_CHECK_LIB(id3, ID3Tag_New) check was failing. Reviewing config.log I found that I needed -lstdc++ and -lz to get the test program to link properly.Â

diff --git a/configure.ac b/configure.ac
index a0ef910..7425572 100644
--- a/configure.ac
+++ b/configure.ac
@@ -46,7 +46,7 @@ AC_INIT([tracker], [tracker_version],
Â
ÂAC_CONFIG_SRCDIR([src/tracker-store/tracker-main.c])
Â
-AM_INIT_AUTOMAKE([no-define tar-ustar])
+AM_INIT_AUTOMAKE([no-define tar-ustar -Wno-portability])
ÂAM_CONFIG_HEADER(config.h)
Â
Âm4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
@@ -250,7 +250,7 @@ AC_ARG_ENABLE(id3lib,
Â
Âif test "x$enable_id3lib" != "xno" ; then
ÂÂÂ AC_CHECK_HEADER(id3.h,
-ÂÂ AC_CHECK_LIB(id3, ID3Tag_New))
+ÂÂ AC_CHECK_LIB([id3], [ID3Tag_New], [], [], [-lstdc++ -lz]))
Â
ÂÂÂ have_id3lib=${ac_cv_lib_id3_ID3Tag_New:-no}

I am using libid3 from Debian's libid3-3.8.3-dev package:

$ dpkg --search /usr/lib/libid3.a
libid3-3.8.3-dev: /usr/lib/libid3.a

$ dpkg --status libid3-3.8.3-dev
Package: libid3-3.8.3-dev
Status: install ok installed
Priority: optional
Section: libdevel
Installed-Size: 880
Maintainer: Stefan Ott <stefan ott net>
Architecture: amd64
Source: id3lib3.8.3
Version: 3.8.3-9
Replaces: libid3-dev
Provides: libid3-dev
Depends: libid3-3.8.3c2a (= 3.8.3-9), zlib1g-dev
Conflicts: libid3-dev
Description: An ID3 Tag Library: Development Libraries and Header Files
ÂThis package contains the headers that programmers will need to develop
Âapplications which will use id3lib, the software library for ID3v1 and ID3v2
Âtag manipulation.
Homepage: http://id3lib.sourceforge.net/

I don't know if the link dependencies are specific to this build of the libid3 library but I don't think adding them to the AC_CHECK_LIB should do any harm in cases where more self-contained libid3 libraries are used for the build.

Finally, I found that a few commands were needed to get the GNU Autotools all setup for running ./configure. I thought the following might be a nice paragraph to add to the README:

diff --git a/README b/README
index 435c33e..8778fd4 100644
--- a/README
+++ b/README
@@ -122,6 +122,18 @@
Â
Â4 Compilation
Â
+Â The git repository contains input to the GNU Autotools however a
+Â number of commands need to be run to initialize GNU Autotools in the
+Â project directory. To setup the GNU Autotools for compilation use
+Â the following commands :
+
+ÂÂÂÂÂÂÂ libtoolize
+ÂÂÂÂÂÂÂ gtkdocize
+ÂÂÂÂÂÂÂ intltoolize
+ÂÂÂÂÂÂÂ touch ChangeLog
+ÂÂÂÂÂÂÂ automake --add-missing
+ÂÂÂÂÂÂÂ autoreconf
+
ÂÂ To compile and install Tracker, use the following commands :
Â
ÂÂÂÂÂÂÂÂ ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var

Let me know if you think these are reasonable patches for README and configure.ac.