Re: [Tracker] Enhancement proposal: Automatic reindexing when adding new extractors



On Wed, 10 Feb 2010 10:32:58 +0100, Philip Van Hoof <spam pvanhoof be>
wrote:
On Wed, 2010-02-10 at 10:17 +0100, Michael Biebl wrote:
2010/2/9 Adrien Bustany <madcat mymadcat com>:

[CUT]

I think, in general the idea is good, I have some concerns though.
Using the mtime, might have some undesired side effects.
E.g. a user upgrades his tracker installation say from 0.7.18 to
0.7.19 (by either using make install or the distro package management
tools)
The mtime of the desktop files will change then. Do we really want to
reindex everything in that case? I don't think so.

nod

Maybe, a more robust solution is to use hashsums for the desktop files
and a version counter.
[Extractor]
Name=Foobar extractor
MimeTypes=application/fooba
Version=1

I agree with this
Yep, makes sense


Using a hashsum will ensure that we don't get spurious reindex
whenever the package is upgraded.
Consider now, that the author of the Foobar extractor has
significantly improved its extractor, and he want's to enforce a
reindex.
He'd then bump the Version counter and the hashsum would change.

Hope this makes sense. Thoughts?

Makes sense to me

Yes, I'll stick with the version number.

Thanks for the feedback!



Cheers,


Philip



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]