Re: [Tracker] PATCH that makes things in tracker-monitor.c more performant
- From: Martyn Russell <martyn imendio com>
- To: Philip Van Hoof <spam pvanhoof be>
- Cc: tracker-list gnome org
- Subject: Re: [Tracker] PATCH that makes things in tracker-monitor.c more performant
- Date: Thu, 02 Apr 2009 13:51:19 +0100
Philip Van Hoof wrote:
On Thu, 2009-04-02 at 14:23 +0200, Philip Van Hoof wrote:
I'm not very sure, but isn't this going to make things faster?
Let me know ...
Added a break, don't know why we would need to continue looping once
found.
Hi Philip,
Superb patch, thanks. What I love is, no memory creation/freeing takes
place with lists and you are right, we were traversing the list twice it
seems with the list and the keys->list.
Just as a note, I changed the code slightly so we return NULL at the
end, return the module name in the inner most block and moved some
variable declarations to the right scope (that was there before though).
The casting there wasn't necessary (const gchar*) and (GHashTable*).
Thanks again, committed!
--
Regards,
Martyn
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]