Re: [Tracker] [patch] split TrackerHal into TrackerStorage and TrackerPower and re-organise into backend

[Martyn Russell <martyn imendio com>]

Richard Hughes wrote:
> The attached patch splits TrackerHal into TrackerStorage and
> TrackerPower to better split the functionalities for future work. This
> is needed for future patches to add DeviceKit support. I've also created
> the files tracker-storage-hal and tracker-power-hal so that the power
> and storage code can be compiled into a HAL or DeviceKit backends in the
> future.
>
> The diffstat looks huge, but it's really just splitting the GObject and
> reorganising the filenames, there are no real logic changes. I've done a
> quick test of trackerd, but it probably needs someone familiar with the
> self tests to check this before it's committed.
>
> [hughsie hughsie-work tracker]$ cat tracker-split-hal.patch | diffstat
>  libtracker-common/Makefile.am           |    6 
>  libtracker-common/tracker-albumart.c    |    6 
>  libtracker-common/tracker-common.h      |    3 
>  libtracker-common/tracker-hal.c         | 1299 --------------------------------
>  libtracker-common/tracker-hal.h         |   78 -
>  libtracker-common/tracker-power-hal.c   |  588 ++++++++++++++
>  libtracker-common/tracker-power.h       |   65 +
>  libtracker-common/tracker-storage-hal.c |  953 +++++++++++++++++++++++
>  libtracker-common/tracker-storage.h     |   74 +
>  tracker-indexer/tracker-indexer.c       |   44 -
>  trackerd/tracker-main.c                 |   62 -
>  trackerd/tracker-processor.c            |   36 
>  trackerd/tracker-processor.h            |    4 
>  trackerd/tracker-status.c               |   10 
>  trackerd/tracker-status.h               |    4 
>  15 files changed, 1773 insertions(+), 1459 deletions(-)
>
> Feedback please. I'll submit further patches when this patch is
> accepted. I have commit on gnome svn if this helps. Thanks.

Hi Richard,

Thanks for drafting up this patch, damn that was quick! :)
I need a little time to review a patch of this size so I will get back 
to you ASAP. From first impressions, it looks good. Will give you a 
proper review shortly.

--
Regards,
Martyn