Re: [Tracker] Database access abstraction

[Jürg Billeter <j bitron ch>]

On Mon, 2008-11-10 at 15:12 +0000, Martyn Russell wrote:
> JÃrg Billeter wrote:
> > On Sat, 2008-11-01 at 01:11 +0000, Martyn Russell wrote:
> > > - tracker_data_query_get_all_metadata(), is that "only_embedded"
> used?
> > > Not sure what it does. Also, the "id" should really be "service_id" so
> > > we know what it is. Variable names like "id" and "key" really don't tell
> > > me what I should pass.
> >
> > Yes, only_embedded is used to filter the results. If only_embedded is
> > TRUE, it won't return values of fields where tracker_field_get_embedded
> > returns FALSE. However, it still retrieves all metadata values from the
> > database, as far as I can tell. Parameter renaming certainly makes
> > sense.
>
> What does the tracker_field_get_embedded() actually mean though?
>
> I would have suggested something more pertinent but I couldn't see what
> it really meant in the first place.

As far as I understand it, a field is embedded if the value is stored
inside a file, for example, as an IDv3 tag in a MP3 file.

I've noticed in the meantime that the function is always called with
only_embedded set to TRUE, so I've renamed the function to
tracker_data_query_embedded_metadata() and removed the parameter.

JÃrg