Re: [Tracker] [PATCH] deskbar handler support for KMail and Thunderbird - untested!



On 9/8/07, Michal Pryc <Michal Pryc sun com> wrote:
Marcus Fritzsch wrote:
On 9/7/07, Mikkel Kamstrup Erlandsen <mikkel kamstrup gmail com> wrote:
2007/9/7, jamie <jamiemcc blueyonder co uk>:

On Thu, 2007-09-06 at 14:27 +0200, Marcus Fritzsch wrote:
Hey there, hey Migi ;)

Heres a test-wise patch for thunderbird and kmail support. This thing
is untested as I have no emails in evo/tb/kmail ;).

mikkel can you review this?
 First note, that I am not on a compuyer where I am able to test this. So I
have not tested this code. Caveat Emptor.

I can't test it either :/

 In the patch' line 26 I expect the 'key' variable to evaluate to the string
"mime". So for this to work self.result['mime'] should contain "Evolution",
"Thunderbird", or "KMail". - Odd to call it "mime" then, no?

 self.result["mime"] is set from the third item in the returned data from
Tracker, so if this really contains the said values, then it should work.
But as I wrote I cannot test atm.

That's exactly why it's called mime, migi told me that tracker returns
the MUA for results of type Emails, migi, can you still confirm this
as it really sounds odd ;). Anyway, I could change that to have a
special key for mail, that would be no problem at all ;)

Hello,
I will just make a point to the source file (line 602-614). The variable
is called mime and it's taken from the function in file:

http://svn.gnome.org/viewcvs/tracker/trunk/src/tracker-search-tool/tracker-search-tool-callbacks.c?annotate=823

Hehe, ok, well, I rethought and here's the cleaned up version which
calles this specific field 'mua'. Can someone test it?

Cheers, Marcus

Attachment: tracker_r823_deskbar_handlers_kmail_and_thunderbird_support.patch
Description: Text Data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]