Re: [Tracker] [PATCH] deskbar handler support for KMail and Thunderbird - untested!



2007/9/7, jamie <jamiemcc blueyonder co uk>:
On Thu, 2007-09-06 at 14:27 +0200, Marcus Fritzsch wrote:
> Hey there, hey Migi ;)
>
> Heres a test-wise patch for thunderbird and kmail support. This thing
> is untested as I have no emails in evo/tb/kmail ;).
>

mikkel can you review this?

First note, that I am not on a compuyer where I am able to test this. So I have not tested this code. Caveat Emptor.

In the patch' line 26 I expect the 'key' variable to evaluate to the string "mime". So for this to work self.result['mime'] should contain "Evolution", "Thunderbird", or "KMail". - Odd to call it "mime" then, no?

self.result["mime"] is set from the third item in the returned data from Tracker, so if this really contains the said values, then it should work. But as I wrote I cannot test atm.

Cheers,
Mikkel




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]