Re: [Tracker] [cc-devel] XMP/CC in Tracker, first patch

[jamie <jamiemcc blueyonder co uk>]

On Sun, 2007-06-10 at 18:52 -0700, Jason Kivlighn wrote:
> > Why .filename.xmp ? It should be basename.xmp (no dot prepended)
> > I don't know where this convention comes from but definitely not the one
> > from the current (non-free) implementations.
> > I'd rather wish we don't reinvent the wheel.
> >   
> Jamie will have to respond on this one.  It'd be convenient to have the
> xmp hidden (Tracker wouldn't index it twice), but following the current
> convention, which I wasn't aware of, would be best.

I agree following the convention would be best - we will have to treat
files ending in .xmp differently so we dont index its metadata twice (we
will want to treat it as an ordinary file but not one that has embedded
metadata)


> > > How does the patch look?  Style?  Approach? etc...  Also, how do I go
> > > about getting commit access?
> > >     
> >
> > xmp_init() cost a lot to call. Same as xmp_terminate(). You should only
> > call then once. Actually xmp_terminate() isn't mandatory as when the
> > programm quits, things will be cleaned up.
> >   
> I'm not sure what can be done about this one.  For each file that is
> indexed, a separate process is spawned.

correct - tracker extracts all embedded metadata out of process for
maximum stability and it also ensures corrupted data files or buggy
extraction libs cant bring the trackerd process down (and is one of the
reasons tracker is more robust in this area than other indexers). 

jamie