Re: [Tracker] [Patch] DBus connection lost handling

[Jamie McCracken <jamiemcc blueyonder co uk>]

Laurent Aguerreche wrote:
> Le lundi 04 septembre 2006 Ã 13:58 +0100, Jamie McCracken a Ãcrit :
> > Jamie McCracken wrote:
> >
> > > (move do_cleanup to tracker-utils.c/.h and make it non static. We can 
> > > probably use tracker->is_running instead of static shutdown variable in 
> > > trackerd.c too?)
> > Actually we will need a tracker->shutdown variable instead of the static 
> > shutdown variable. Shutdown is used to tell threads to stop (when 
> > asleep) while tracker->is_running encourages them to sleep so they are 
> > different.
>
> If I move do_cleanup() in tracker-utils.c, I also need to make
> main_connection a field a tracker structure.

I couldn't apply your patch cleanly as I have been changing stuff over 
the last few days and I wasn't expecting such large changes from you.

I have now committed my changes.

Would it be okay for you to have a look and try patching it against 
latest CVS?

Most of it will get through but there are a few that will fail. I wont 
have time until the weekend to sort it out unless you can do anything 
with this in the meantime.

(NB trackerd.h is not used!)

Otherwise your patch looks good to apply in the full - thanks :)


--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/