Re: [Tracker] [PATCH] Re: Various errors with tracker-tag

[Jamie McCracken <jamiemcc blueyonder co uk>]

Ulrik Mikaelsson wrote:
> Howdy!
>
> 1) Could reproduce, but not solve. It seems like the ServiceWords table 
> is not at all defined in the sqlite, OR the mysql DDL, but is referenced 
> in both implementations stored procedures? Should they be?

yes its defined in tracker-db-sqlite.c and its a temporary cache DB in /tmp

I have now fixed that error


> 2) Fixed by the attached patch
>
> 3) Fixed by the attached patch.
>
> I also took the liberty to clean some memory-leaks where string-arrays 
> were not freed, and introduce error-handling for all 
> dbus_message_get_args-calls in tracker-dbus-keywords.c, as I did with 
> tracker-dbus-files.c.
>
> About my solution of prob #2, one could perhaps argue that writing 
> "<filename>: file not found" is not the best of ideas, since parsing of 
> the output might interpret this as a file with the tags "file, not, 
> found". While better suggestions are always welcome, I would like to 
> point out that this error message goes to STDERR, while normal output is 
> written to STDOUT, and a decent script should be able to handle the 
> difference.

perhaps but Im happy with what you have so far

thanks - have now applied



--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/