[Tracker] [PATCH] Re: Various errors with tracker-tag

["Ulrik Mikaelsson" <ulrik mikaelsson gmail com>]

Howdy!

1) Could reproduce, but not solve. It seems like the ServiceWords table is not at all defined in the sqlite, OR the mysql DDL, but is referenced in both implementations stored procedures? Should they be?

2) Fixed by the attached patch

3) Fixed by the attached patch.

I also took the liberty to clean some memory-leaks where string-arrays were not freed, and introduce error-handling for all dbus_message_get_args-calls in 
tracker-dbus-keywords.c, as I did with tracker-dbus-files.c.

About my solution of prob #2, one could perhaps argue that writing "<filename>: file not found" is not the best of ideas, since parsing of the output might interpret this as a file with the tags "file, not, found". While better suggestions are always welcome, I would like to point out that this error message goes to STDERR, while normal output is written to STDOUT, and a decent script should be able to handle the difference.

Regards
/ Ulrik

On 10/17/06, Baptiste Mille-Mathias <baptiste millemathias gmail com > wrote:

Hello,

While I was playing with tracker-tag to write a man page I found some errors.


1Â) Warning / error
with
tracker-tag -a HOME /home/baptiste/
and
tracker-tag -R /home/baptiste/

I have this output in tracker.log
===================================
adding keywords to /home/baptiste with id 1153
ERROR : failed to prepare query ServiceCached with sql select 1 from
ServiceWords where ServiceID = ? and WordID = (select WordID from
Words where Word = ?);
due to no such table: ServiceWords
ERROR : prepared query ServiceCached failed due to no such table: ServiceWords
===================================

2Â) Segfault
With
(((baptiste linbox)))-> tracker-tag -R HOME /home/baptiste/
segmentation fault (core dumped)
(note that I should have done tracker-tag -R /home/baptiste/)

same result if one give too much parameters than expected.

3Â) Inconsistency
a. (((baptiste linbox)))-> tracker-tag -s HOME
HOME
b. (((baptiste linbox)))-> tracker-tag -a HOME /home/baptiste/
c. (((baptiste linbox)))-> tracker-tag -s HOME
/home/baptiste

the output of step a. gives the name of the tag, but not on the step
c.; I don't know if they be the same.

Hope it helps

Regards :)
--
Baptiste Mille-Mathias
Les gens heureux ne sont pas pressÃs
_______________________________________________
tracker-list mailing list
tracker-list gnome org
http://mail.gnome.org/mailman/listinfo/tracker-list

Attachment: tracker-tag-fixes.patch
Description: Text Data