Re: [Tracker] invalid field causes trackerd to quit

[Jamie McCracken <jamiemcc blueyonder co uk>]

Ulrik Mikaelsson wrote:
> Hmm, the punishment of incorporating my patches is getting more of them. ;)
>
> Here's one that does the following;
>
> * Fixes the mentioned field-checking issue.
> * Fixes an issue with the symptoms that when you call 
> GetMetadataForFilesInFolder(-1, <aFolder>, <aString>), tracker chews up 
> all the memory and dies.
>  + This issue is probably present in just about all the functions of 
> this file, and is fixed for this file. (Not other dbus-interfaces, 
> though. It's a lot of boring work to deal with error-handling.)
> * Fixes a memory-leak in GetMetadataForFilesInFolder, where the string 
> array of the message were not free:d as mentioned in 
> http://dbus.freedesktop.org/doc/api/html/group__DBusMessage.html#gaa5e339a728a7baa786e6c30e3b840b7
>
> Please check this out, and see if it's of any use to you.

yes it looks good

I will apply later (post 0.5.0) and fix up the other interfaces so we 
are more robust here.

Im busy getting the build of rpms of tracker 0.5.0 out the door atm so 
it will probably be tomorrow.

Thanks for your hard work here - its most appreciated.


--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/