Re: Please could someone remove that bug in tny-session-camel.c?

[Philip Van Hoof <spam pvanhoof be>]

Sergio,

Can you take a look at this?

It looks like this already creates a msg instance that is right, and
where the functions don't need to be overwritten.

CamelSessionThreadMsg *msg = ms_parent_class->thread_msg_new(session,
ops, size);

But given that this is untested against Modest, I assume we want to make
sure and test and then test it again.

Cheers,

Philip

On Fri, 2010-07-02 at 10:05 +0200, Philip Van Hoof wrote:
> Your patches don't solve any problem, you just ifdef lines away.
> 
> Instead you should free msg->ops at the location where the
> CamelSessionThreadMsg gets freed, if it is indeed a leak.
> 
> But I'm sure that if you attitude stays like that, that you'll be simply
> flat out ignored.
> 
> Cheers
> 
> Philip
> 
> On Fri, 2010-07-02 at 00:51 -0700, tinymail mexon spamgourmet com wrote:
> > What did I just do?  Ask you out on a date?
> > 
> > Or do you mean "propose a patch" like this?
> > http://mail.gnome.org/archives/tinymail-devel-list/2010-March/msg00004.html
> > 
> > Or this?
> > http://tinymail.org/trac/tinymail/ticket/91
> > 
> > Or this?
> > http://mat.exon.name/modest
> > 
> > Or possibly even these?
> > http://talk.maemo.org/showthread.php?p=574423#post574423
> > http://talk.maemo.org/showthread.php?t=55771
> > 
> > ----- Original message -----
> > > Why don't _you_ just propose a patch?
> > > 
> > > On Thu, 2010-07-01 at 19:07 +0100, tinymail mexon spamgourmet com wrote:
> > > > Lines 619 to 623, according to git.   Please please please pretty
> > > > please   could someone just delete those lines?   If not to fix the
> > > > functionality,   than at least in order to clean up the memory leak? 
> > > > Please?
> > > > 
> > > > I mean, I'm trying to be patient and stuff, but it's not really a lot
> > > > of   work I'm asking for here...
> > > > 
> > > >     msg->ops = g_new0 (CamelSessionThreadOps,1);
> > > >     msg->ops->free = my_free_func;
> > > >     msg->ops->receive = my_receive_func;
> > > >     msg->data = NULL;
> > > >     msg->op = camel_operation_new (my_cancel_func, NULL);
> > > > 
> > > > http://tinymail.org/trac/tinymail/ticket/91
> > > 
> > > 
> > > -- 
> > > 
> > > 
> > > Philip Van Hoof
> > > freelance software developer
> > > Codeminded BVBA - http://codeminded.be
> > > 
> > >
> > 
> > 
> >       
> > 
> > _______________________________________________
> > tinymail-devel-list mailing list
> > tinymail-devel-list gnome org
> > http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
> > 
> 

-- 


Philip Van Hoof
freelance software developer
Codeminded BVBA - http://codeminded.be