Re: Review request: Message reply fix for MfE

[Sergio Villar Senin <svillar igalia com>]

Hi Alexander,

A few comments:
  * First of all, patch is great, thank you for contributing
  * Secondly, do not include links to Nokia's internal bugzilla in
comments of tinymail's bugs. It makes no sense at all, since people
cannot access to them. Instead, please describe the issue in tinymail
without mentioning the specific use case you're fixing for modest.
  * Finally, please include in the patch a nice ChangeLog entry :)

Br

Alexander Chumakov escribiu:
> Hello all,
> Please, review the attached patch and integrate it if it looks fine.
> Here is some info:
> 1) Baseline code location:
> URL: http://git.gitorious.org/tinymail/tinymail.git
> Branch: tinymail-1-2
> Commit: 5ad7626d4119f1d045941425b0873aa36190458c
> 
> 2) Fixed bug:  158769 - Edited response not delivered for an Accepted
> meeting request;
> Link: https://projects.maemo.org/bugzilla/show_bug.cgi?id=158769
> 
> 3) Fix information:
> The original bug was submitted for meeting requests, but the issue is
> reproducible for ordinary emails also.
> Modest receives an email from recipient with email address like this:
> From: "Nangunoori Naveen.K (EXT-Wipro/Helsinki)"\r\n
> <ext-naveen k nangunoori nokia com>
> Here '\r\n' is the new line marker.
> When the user presses 'reply all' Modest forms string for 'To:' like
> this: "Nangunoori Naveen.K (EXT-Wipro/Helsinki)"\r\n
> <ext-naveen k nangunoori nokia com>
> Modest passes this email address to 'tny_header_set_to (new_header,
> new_to)' -> '_foreach_email_add_to_inet_addr ()' ->
> '_string_to_camel_inet_addr ()';
> In its turn, _string_to_camel_inet_addr () transforms:
> ["Nangunoori Naveen.K (EXT-Wipro/Helsinki)"\r\n] => [Nangunoori Naveen.K
> (EXT-Wipro/Helsinki)"]
> Here, the trailing \" is not removed. Now, the email address is
> considered to be:
> "Nangunoori Naveen.K (EXT-Wipro/Helsinki)\""
> <ext-naveen k nangunoori nokia com>
> The email address has extra \" character. According to the RFCs the
> email address is still valid, but it is NOT valid for MS Exchange
> servers and it rejects such an address.
> I added stripping (removing whitespaces) the name before \" characters
> are removed. This fixes this particular issue.
> 
> Please, let me know if something is wrong with this fix.
> 
> Thank you,
> Alexander
> 
> 
> Alexander Chumakov
> Architect
> 
> Teleca
> 24 Salganskaya St., Nizhny Novgorod, 603105, Russia
> Phone: +78312788198, Fax: +78312577230
> Alexander Chumakov teleca com
> http://www.teleca.com/
> 
> Follow what's going on at Teleca's blog on
> http://www.whatsyourideaoftomorrow.blogspot.com/.
> 
> The information contained in this message is confidential and is
> intended for the addressee(s) only. If you have received this message in
> error please notify the sender immediately. The unauthorized use,
> disclosure, copying or alteration of this message is strictly prohibited.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list